Re: [PATCH -next 1/2] net: dsa: qca8k: check return value of read functions correctly

[Jakub Kicinski]

On Fri, 28 May 2021 16:22:39 +0800 Yang Yingliang wrote:
> @@ -1793,14 +1783,15 @@ static int qca8k_read_switch_id(struct qca8k_priv *priv)
>  	const struct qca8k_match_data *data;
>  	u32 val;
>  	u8 id;
> +	int ret;

ret before id to keep the reverse xmas tree ordering