Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups

From: Andy Shevchenko
Date: Sat May 29 2021 - 05:47:04 EST


On Fri, May 28, 2021 at 1:50 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Fri, May 28, 2021 at 12:09:06PM +0200, Pavel Machek wrote:
> > On Mon 2021-05-10 12:50:28, Andy Shevchenko wrote:
> > > The idea of managed resources that they will be cleaned up automatically
> > > and in the proper order. Remove explicit cleanups.
> >
> > Are you really sure this is good idea with the regmap_update_bits in
> > between?
>
> Good question. I will check it.
>
> > > - /* unregister led */
> > > - devm_led_classdev_unregister(priv->dev, &led->cdev);

I left this untouched, i.o.w. no removal in v2.

--
With Best Regards,
Andy Shevchenko