Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare_buffer()

From: YueHaibing
Date: Sat May 29 2021 - 09:24:39 EST


On 2021/5/29 20:11, Greg KH wrote:
> On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote:
>> A coccicheck run provided information like the following.
>>
>> ./drivers/usb/gadget/function/f_fs.c:3832:9-16:
>> WARNING: ERR_CAST can be used with data
>>
>> ffs_prepare_buffer() should return an ERR_PTR() encoded error
>> code on failure.
>
> It does return such a pointer today, so this statement does not make
> much sense :(

Yes, it does. This is just to remove explicit casts.

>
> And is this a v2 patch? What changed from the previous version?

Sorry, I forget to add version info.

>
> thanks,
>
> greg k-h
> .
>