mm/migrate.c:1406:5: warning: stack frame size of 2096 bytes in function 'migrate_pages'

From: kernel test robot
Date: Sun May 30 2021 - 05:52:00 EST

Next message:
Previous message:
Next in thread:
Messages sorted

tree: config: powerpc-randconfig-r034-20210530 compiler: clang version 13.0.0 ( wget # install powerpc # apt-get install # If you fix the issue, Reported-by: kernel test
All warnings (new ones
In file included from In file included from In file included from In file included from In file included from In file included from In file included from In file included from In file included from In file included from arch/powerpc/include/asm/barrier.h:49:9: #define __lwsync() ^
<built-in>:309:9: #define __lwsync __builtin_p ^
>> mm/migrate.c:1406:5: int migrate_pages(struct ^
2 warnings generated.

vim +/migrate_pages +1406
290408d4a25002 Naoya Horiguchi e24f0b8f76cc3d Christoph Lameter c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat e24f0b8f76cc3d Christoph Lameter c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat 68711a746345c4 David Rientjes 68711a746345c4 David Rientjes c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat e24f0b8f76cc3d Christoph Lameter c73e5c9c59a0f7 Srivatsa S. Bhat c73e5c9c59a0f7 Srivatsa S. Bhat dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi e24f0b8f76cc3d Christoph Lameter c73e5c9c59a0f7 Srivatsa S. Bhat e24f0b8f76cc3d Christoph Lameter 9c620e2bc5aa42 Hugh Dickins 68711a746345c4 David Rientjes 68711a746345c4 David Rientjes e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual e24f0b8f76cc3d Christoph Lameter 5647bc293ab15f Mel Gorman 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual dd4ae78a21fc05 Yang Shi e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 94723aafb9e764 Michal Hocko 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 6c5c7b9f335272 Zi Yan 6c357848b44b40 Matthew Wilcox (Oracle e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 31caf665e666b5 Naoya Horiguchi 31caf665e666b5 Naoya Horiguchi 68711a746345c4 David Rientjes dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi 31caf665e666b5 Naoya Horiguchi 68711a746345c4 David Rientjes add05cecef803f Naoya Horiguchi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi e24f0b8f76cc3d Christoph Lameter 95a402c3847cc1 Christoph Lameter 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 6c5c7b9f335272 Zi Yan 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 1a5bae25e3cf95 Anshuman Khandual 94723aafb9e764 Michal Hocko 94723aafb9e764 Michal Hocko 6c5c7b9f335272 Zi Yan 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual dfef2ef4027b13 David Rientjes 95a402c3847cc1 Christoph Lameter e24f0b8f76cc3d Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual b20a35035f983f Christoph Lameter e24f0b8f76cc3d Christoph Lameter 78bd52097d0420 Rafael Aquini 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 5647bc293ab15f Mel Gorman e24f0b8f76cc3d Christoph Lameter e24f0b8f76cc3d Christoph Lameter 354a3363363724 Naoya Horiguchi 354a3363363724 Naoya Horiguchi 354a3363363724 Naoya Horiguchi 354a3363363724 Naoya Horiguchi 354a3363363724 Naoya Horiguchi 354a3363363724 Naoya Horiguchi 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual b20a35035f983f Christoph Lameter e24f0b8f76cc3d Christoph Lameter 2d1db3b1170db4 Christoph Lameter b20a35035f983f Christoph Lameter b20a35035f983f Christoph Lameter 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual f2f81fb2b72b83 Vlastimil Babka 95a402c3847cc1 Christoph Lameter dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi dd4ae78a21fc05 Yang Shi 5647bc293ab15f Mel Gorman 5647bc293ab15f Mel Gorman 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 1a5bae25e3cf95 Anshuman Khandual 7b2a2d4a18fffa Mel Gorman b20a35035f983f Christoph Lameter b20a35035f983f Christoph Lameter b20a35035f983f Christoph Lameter 95a402c3847cc1 Christoph Lameter b20a35035f983f Christoph Lameter b20a35035f983f Christoph Lameter
:::::: The code at line :::::: 9c620e2bc5aa4256c102ada3
:::::: TO: Hugh Dickins :::::: CC: Linus Torvalds
---
0-DAY CI Kernel Test Service, Description: application/gzip Maxim Levitsky: "Re: [PATCH v5 09/11] KVM: X86: Add vendor callbacks for writing the TSC multiplier" Christian Lamparter: "Re: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings" Andrew Morton: "Re: mm/migrate.c:1406:5: warning: stack frame size of 2096 bytes in function 'migrate_pages'" by: [ date ] [ thread ] [ subject ] [ author ] href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
08bf4713a42353af6
99dddd057ad64a4df mm: migrate: simplify the logic for handling permanent failure
(attached as .config)
rel="nofollow" href="https://github.com/llvm/llvm-project">https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
cross compiling tool for clang build
binutils-powerpc-linux-gnu
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd4ae78a21fc05d91d841e499dddd057ad64a4df">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd4ae78a21fc05d91d841e499dddd057ad64a4df
rel="nofollow" href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
linus master
fc05d91d841e499dddd057ad64a4df
.config to linux build tree
COMPILER=clang make.cross ARCH=powerpc
kindly add following tag as appropriate
robot <lkp@xxxxxxxxx>
prefixed by >>):
mm/migrate.c:16:
include/linux/migrate.h:5:
include/linux/mm.h:9:
include/linux/mmdebug.h:5:
include/linux/bug.h:5:
arch/powerpc/include/asm/bug.h:109:
include/asm-generic/bug.h:20:
include/linux/kernel.h:12:
include/linux/bitops.h:29:
arch/powerpc/include/asm/bitops.h:62:
warning: '__lwsync' macro redefined [-Wmacro-redefined]
__asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
note: previous definition is here
pc_lwsync
warning: stack frame size of 2096 bytes in function 'migrate_pages' [-Wframe-larger-than=]
list_head *from, new_page_t get_new_page,
mm/migrate.c
2010-09-08 1384
2006-06-23 1385 /*
2013-04-29 1386 * migrate_pages - migrate the pages specified in a list, to the free pages
2013-04-29 1387 * supplied as the target for the page migration
2006-06-23 1388 *
2013-04-29 1389 * @from: The list of pages to be migrated.
2013-04-29 1390 * @get_new_page: The function used to allocate free pages to be used
2013-04-29 1391 * as the target of the page migration.
2014-06-04 1392 * @put_new_page: The function used to free target pages if migration
2014-06-04 1393 * fails, or NULL if no special handling is necessary.
2013-04-29 1394 * @private: Private data to be passed on to get_new_page()
2013-04-29 1395 * @mode: The migration mode that specifies the constraints for
2013-04-29 1396 * page migration, if any.
2013-04-29 1397 * @reason: The reason for page migration.
2006-06-23 1398 *
2013-04-29 1399 * The function returns after 10 attempts or if no pages are movable any more
2013-04-29 1400 * because the list has become empty or no retryable pages exist any more.
2020-12-14 1401 * It is caller's responsibility to call putback_movable_pages() to return pages
2020-12-14 1402 * to the LRU or free list only if ret != 0.
2006-06-23 1403 *
2013-04-29 1404 * Returns the number of pages that were not migrated, or an error code.
2006-06-23 1405 */
2013-02-22 @1406 int migrate_pages(struct list_head *from, new_page_t get_new_page,
2014-06-04 1407 free_page_t put_new_page, unsigned long private,
2014-06-04 1408 enum migrate_mode mode, int reason)
2006-06-23 1409 {
2006-06-23 1410 int retry = 1;
2020-08-11 1411 int thp_retry = 1;
2006-06-23 1412 int nr_failed = 0;
2012-10-19 1413 int nr_succeeded = 0;
2020-08-11 1414 int nr_thp_succeeded = 0;
2020-08-11 1415 int nr_thp_failed = 0;
2020-08-11 1416 int nr_thp_split = 0;
2006-06-23 1417 int pass = 0;
2020-08-11 1418 bool is_thp = false;
2006-06-23 1419 struct page *page;
2006-06-23 1420 struct page *page2;
2006-06-23 1421 int swapwrite = current->flags & PF_SWAPWRITE;
2020-08-11 1422 int rc, nr_subpages;
2020-12-14 1423 LIST_HEAD(ret_pages);
2006-06-23 1424
2006-06-23 1425 if (!swapwrite)
2006-06-23 1426 current->flags |= PF_SWAPWRITE;
2006-06-23 1427
2020-08-11 1428 for (pass = 0; pass < 10 && (retry || thp_retry); pass++) {
2006-06-23 1429 retry = 0;
2020-08-11 1430 thp_retry = 0;
2006-06-23 1431
2006-06-23 1432 list_for_each_entry_safe(page, page2, from, lru) {
2018-04-10 1433 retry:
2020-08-11 1434 /*
2020-08-11 1435 * THP statistics is based on the source huge page.
2020-08-11 1436 * Capture required information that might get lost
2020-08-11 1437 * during migration.
2020-08-11 1438 */
2020-09-25 1439 is_thp = PageTransHuge(page) && !PageHuge(page);
2020-08-14 1440) nr_subpages = thp_nr_pages(page);
2006-06-23 1441 cond_resched();
2006-06-23 1442
2013-09-11 1443 if (PageHuge(page))
2013-09-11 1444 rc = unmap_and_move_huge_page(get_new_page,
2014-06-04 1445 put_new_page, private, page,
2020-12-14 1446 pass > 2, mode, reason,
2020-12-14 1447 &ret_pages);
2013-09-11 1448 else
2014-06-04 1449 rc = unmap_and_move(get_new_page, put_new_page,
2015-06-24 1450 private, page, pass > 2, mode,
2020-12-14 1451 reason, &ret_pages);
2020-12-14 1452 /*
2020-12-14 1453 * The rules are:
2020-12-14 1454 * Success: non hugetlb page will be freed, hugetlb
2020-12-14 1455 * page will be put back
2020-12-14 1456 * -EAGAIN: stay on the from list
2020-12-14 1457 * -ENOMEM: stay on the from list
2020-12-14 1458 * Other errno: put on ret_pages list then splice to
2020-12-14 1459 * from list
2020-12-14 1460 */
2006-06-23 1461 switch(rc) {
2006-06-23 1462 case -ENOMEM:
2018-04-10 1463 /*
2018-04-10 1464 * THP migration might be unsupported or the
2018-04-10 1465 * allocation could've failed so we should
2018-04-10 1466 * retry on the same page with the THP split
2018-04-10 1467 * to base pages.
2018-04-10 1468 *
2018-04-10 1469 * Head page is retried immediately and tail
2018-04-10 1470 * pages are added to the tail of the list so
2018-04-10 1471 * we encounter them after the rest of the list
2018-04-10 1472 * is processed.
2018-04-10 1473 */
2020-09-25 1474 if (is_thp) {
2018-04-10 1475 lock_page(page);
2018-04-10 1476 rc = split_huge_page_to_list(page, from);
2018-04-10 1477 unlock_page(page);
2018-04-10 1478 if (!rc) {
2018-04-10 1479 list_safe_reset_next(page, page2, lru);
2020-08-11 1480 nr_thp_split++;
2018-04-10 1481 goto retry;
2018-04-10 1482 }
2020-09-25 1483
2020-08-11 1484 nr_thp_failed++;
2020-08-11 1485 nr_failed += nr_subpages;
2020-08-11 1486 goto out;
2020-08-11 1487 }
2016-05-20 1488 nr_failed++;
2006-06-23 1489 goto out;
2006-06-23 1490 case -EAGAIN:
2020-08-11 1491 if (is_thp) {
2020-08-11 1492 thp_retry++;
2020-08-11 1493 break;
2020-08-11 1494 }
2006-03-22 1495 retry++;
2006-06-23 1496 break;
2012-12-11 1497 case MIGRATEPAGE_SUCCESS:
2020-08-11 1498 if (is_thp) {
2020-08-11 1499 nr_thp_succeeded++;
2020-08-11 1500 nr_succeeded += nr_subpages;
2020-08-11 1501 break;
2020-08-11 1502 }
2012-10-19 1503 nr_succeeded++;
2006-06-23 1504 break;
2006-06-23 1505 default:
2014-01-21 1506 /*
2014-01-21 1507 * Permanent failure (-EBUSY, -ENOSYS, etc.):
2014-01-21 1508 * unlike -EAGAIN case, the failed page is
2014-01-21 1509 * removed from migration page list and not
2014-01-21 1510 * retried in the next outer loop.
2014-01-21 1511 */
2020-08-11 1512 if (is_thp) {
2020-08-11 1513 nr_thp_failed++;
2020-08-11 1514 nr_failed += nr_subpages;
2020-08-11 1515 break;
2020-08-11 1516 }
2006-03-22 1517 nr_failed++;
2006-06-23 1518 break;
2006-06-23 1519 }
2006-03-22 1520 }
2006-03-22 1521 }
2020-08-11 1522 nr_failed += retry + thp_retry;
2020-08-11 1523 nr_thp_failed += thp_retry;
2015-11-05 1524 rc = nr_failed;
2006-06-23 1525 out:
2020-12-14 1526 /*
2020-12-14 1527 * Put the permanent failure page back to migration list, they
2020-12-14 1528 * will be put back to the right list by the caller.
2020-12-14 1529 */
2020-12-14 1530 list_splice(&ret_pages, from);
2020-12-14 1531
2012-10-19 1532 count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded);
2012-10-19 1533 count_vm_events(PGMIGRATE_FAIL, nr_failed);
2020-08-11 1534 count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded);
2020-08-11 1535 count_vm_events(THP_MIGRATION_FAIL, nr_thp_failed);
2020-08-11 1536 count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split);
2020-08-11 1537 trace_mm_migrate_pages(nr_succeeded, nr_failed, nr_thp_succeeded,
2020-08-11 1538 nr_thp_failed, nr_thp_split, mode, reason);
2012-10-19 1539
2006-03-22 1540 if (!swapwrite)
2006-03-22 1541 current->flags &= ~PF_SWAPWRITE;
2006-03-22 1542
2006-06-23 1543 return rc;
2006-03-22 1544 }
2006-03-22 1545
1406 was first introduced by commit
4e6c76204ed5898b mm: remove offlining arg to migrate_pages
<hughd@xxxxxxxxxx>
<torvalds@xxxxxxxxxxxxxxxxxxxx>
Intel Corporation
//lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Maxim Levitsky: "Re: [PATCH v5 09/11] KVM: X86: Add vendor callbacks for writing the TSC multiplier"
Previous message: Christian Lamparter: "Re: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings"
Next in thread: Andrew Morton: "Re: mm/migrate.c:1406:5: warning: stack frame size of 2096 bytes in function 'migrate_pages'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]