Re: [PATCH] My First Patch - Gabriel e Felipe

[Bhaskar Chowdhury]

On 14:47 Sun 30 May 2021, gkis wrote:
> Signed-off-by: gkis <gabrielkis65@xxxxxxxxx>
> ---
> init/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/init/main.c b/init/main.c
> index 598e278b4..bc366b166 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1082,6 +1082,7 @@ static int __ref kernel_init(void *unused)
> 	numa_default_policy();
>
> 	rcu_end_inkernel_boot();
> +	printk(KERN_ERR "###################################\nI can hack the Linux kernel!\n###################################\n");
>
> 	if (ramdisk_execute_command) {
> 		ret = run_init_process(ramdisk_execute_command);
> --
> 2.17.1

Hi Gabriel,

 Thanks for your effort to and time to contribute to the project we love and
 work with.

 Two nit picking ...as you mentioned it is your "first patch" ...early heads
 up..

 1) Please write a "to the point" Changelog while submitting a patch. It is
 greatly help the maintainer to understand "motive" and "problem solving"
 stuff from it. Also Please mention "Why" the change is needed than "what" is
 changed.

 2) Kindly use your Full and Actual name in the sign off line. I believe
 "gkis" is not the legal name you will go. If it is , then pardon my
 understanding.

 I am CCing this to people , who are long attach to this project and know exactly
 what needs to be done.

 Thanks,
 Bhaskar

Attachment: signature.asc
Description: PGP signature