Re: [PATCH v2] fb_defio: Remove custom address_space_operations

From: Nathan Chancellor
Date: Sun May 30 2021 - 18:40:57 EST

On 5/30/2021 2:14 PM, Matthew Wilcox wrote:
On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote:
Hi Matthew,

On Wed, Mar 10, 2021 at 06:55:30PM +0000, Matthew Wilcox (Oracle) wrote:
There's no need to give the page an address_space. Leaving the
page->mapping as NULL will cause the VM to handle set_page_dirty()
the same way that it's handled now, and that was the only reason to
set the address_space in the first place.

Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>

This patch in mainline as commit ccf953d8f3d6 ("fb_defio: Remove custom
address_space_operations") causes my Hyper-V based VM to no longer make
it to a graphical environment.

Hi Nathan,

Thanks for the report. I sent Daniel a revert patch with a full
explanation last week, which I assume he'll queue up for a pull soon.
You can just git revert ccf953d8f3d6 for yourself until that shows up.
Sorry for the inconvenience.

Thank you for the quick response! I will keep an eye out for the patch while reverting it locally in the meantime.