Re: [PATCH V5 2/3] riscv: Add ASID-based tlbflushing methods

From: Guo Ren
Date: Mon May 31 2021 - 08:20:47 EST


On Mon, May 31, 2021 at 2:17 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Sun, May 30, 2021 at 04:49:25PM +0000, guoren@xxxxxxxxxx wrote:
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > Implement optimized version of the tlb flushing routines for systems
> > using ASIDs. These are behind the use_asid_allocator static branch to
> > not affect existing systems not using ASIDs.
>
> I still think the code duplication and exposing of new code in a global
> header here is a bad idea and would suggest the version I sent instead.
Your idea is in the third patch, and I also add you with
Co-developed-by. Please have a look:

https://lore.kernel.org/linux-riscv/1622393366-46079-4-git-send-email-guoren@xxxxxxxxxx/T/#u

[PATCH V5 3/3] riscv: tlbflush: Optimize coding convention


--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/