Re: [PATCH rdma-next] RDMA: Fix kernel-doc warnings about wrong comment
From: Jinpu Wang
Date: Mon May 31 2021 - 08:32:04 EST
On Mon, May 31, 2021 at 2:03 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Compilation with W=1 produces warnings similar to the below.
>
> drivers/infiniband/ulp/ipoib/ipoib_main.c:320: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
>
> All such occurrences were found with the following one line
> git grep -A 1 "\/\*\*" drivers/infiniband/
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
> * Straightforward change to make our CI happy.
> ---
> drivers/infiniband/core/iwpm_util.h | 2 +-
> drivers/infiniband/core/roce_gid_mgmt.c | 5 +++--
> drivers/infiniband/hw/hfi1/chip.c | 4 ++--
> drivers/infiniband/hw/hfi1/file_ops.c | 6 +++---
> drivers/infiniband/hw/hfi1/hfi.h | 2 +-
> drivers/infiniband/hw/hfi1/init.c | 4 ++--
> drivers/infiniband/hw/hfi1/pio.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw.h | 3 ---
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 10 +++++-----
> drivers/infiniband/hw/i40iw/i40iw_hmc.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw_utils.c | 2 +-
> drivers/infiniband/sw/rdmavt/mr.c | 4 ++--
> drivers/infiniband/sw/rdmavt/qp.c | 3 ++-
> drivers/infiniband/sw/rdmavt/vt.c | 4 ++--
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++---
> drivers/infiniband/ulp/iser/iser_verbs.c | 2 +-
> drivers/infiniband/ulp/isert/ib_isert.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 4 ++--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +-
for rtrs, looks good to me, thx!
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxx>