Re: [PATCH V2] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

[yukuai (C)]

On 2021/05/31 18:54, Robert Foss wrote:
> Hey Yu,
>
> I'm not finding your this patch with the correct tags. I'd expect the subject:
> [PATCH v2] drm: bridge: cdns-mhdp8546: Fix PM reference leak in
> cdns_mhdp_probe()
>
> Can you please resubmit using this title, just to be sure I merge the
> right version of this code.
Hi,

I just resubmit v2 patch.

Thanks
Yu Kuai
> On Sat, 29 May 2021 at 11:46, Yu Kuai <yukuai3@xxxxxxxxxx> wrote:
> > pm_runtime_get_sync will increment pm usage counter even it failed.
> > Forgetting to putting operation will result in reference leak here.
> > Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> > counter balanced.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> > ---
> > changes in V2:
> >   - change error message.
> >
> >   drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> > index 0cd8f40fb690..eab959a59214 100644
> > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> > @@ -2478,9 +2478,9 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
> >          clk_prepare_enable(clk);
> >
> >          pm_runtime_enable(dev);
> > -       ret = pm_runtime_get_sync(dev);
> > +       ret = pm_runtime_resume_and_get(dev);
> >          if (ret < 0) {
> > -               dev_err(dev, "pm_runtime_get_sync failed\n");
> > +               dev_err(dev, "pm_runtime_resume_and_get failed\n");
> >                  pm_runtime_disable(dev);
> >                  goto clk_disable;
> >          }
> > --
> > 2.25.4
> .