Re: [Freedreno] [PATCH v2 2/2] dt-bindings: display: msm/dsi: add qcom, dsi-phy-cphy-mode option

[Dmitry Baryshkov]

On 28/05/2021 15:57, Jonathan Marek wrote:
> On 5/3/21 1:11 PM, Rob Herring wrote:
> > On Fri, Apr 23, 2021 at 01:24:40PM -0400, Jonathan Marek wrote:
> > > Document qcom,dsi-phy-cphy-mode option, which can be used to control
> > > whether DSI will operate in D-PHY (default) or C-PHY mode.
> >
> > Given this is a standard MIPI thing, I think this needs to be a common
> > property. We already have phy bindings that use the phy cells to set the
> > phy type which I think you should use here. See
> > include/dt-bindings/phy/phy.h.
>
> Is it OK to simply change the option to something like "phy-mode = 
> <PHY_TYPE_DSI_CPHY>;"?
>
> (using phy-cells would be annoying to implement, with no benefit IMO)


To add another feather to the balance scales:

- `phys = <&dsi0_phy PHY_TYPE_DSI_CPHY>;` would bring knowledge about 
PHY mode to the DSI host (which does not really care about PHY mode)

- `phy-mode = <PHY_TYPE_DSI_CPHY>;` would stay in the PHY node, where 
this information belongs.

--
With best wishes
Dmitry