Re: [PATCH 4.4 35/54] ALSA: sb8: Add a comment note regarding an unused pointer

[Sasha Levin]

On Mon, May 31, 2021 at 10:36:38PM +0200, Pavel Machek wrote:
> Hi!
>
> > [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ]
> >
> > The field "fm_res" of "struct snd_sb8" is never used/dereferenced
> > throughout the sb8.c code. Therefore there is no need for any null value
> > check after the "request_region()".
> >
> > Add a comment note to make developers know about this and prevent any
> > "NULL check" patches on this part of code.
> >
> > Cc: Takashi Iwai <tiwai@xxxxxxx>
> > Signed-off-by: Atul Gopinathan <atulgopinathan@xxxxxxxxx>
> > Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> This simply adds a comment... As I'm pretty sure anyone trying to
> "fix" this will try that on mainline, it is even very useful comment.
>
> That's something our documentation says we don't do in stable. I'd
> prefer it not to be in.

Now dropped, thanks!

--
Thanks,
Sasha