Re: [PATCH] media: sp8870: move it to staging

[Mauro Carvalho Chehab]

Em Tue, 1 Jun 2021 06:50:54 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu:

> On Mon, May 31, 2021 at 10:37:54PM +0200, Mauro Carvalho Chehab wrote:
> > This driver is used only ba av7110, which is preparing for
> > its retirement. So, move this ancillary driver to stay together
> > with av7110.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > ---
> >  drivers/media/dvb-frontends/Kconfig           | 12 -----------
> >  drivers/media/dvb-frontends/Makefile          |  1 -
> >  drivers/staging/media/av7110/Kconfig          | 20 +++++++++++++++++++
> >  drivers/staging/media/av7110/Makefile         |  2 ++
> >  .../media/av7110}/sp8870.c                    |  0
> >  .../media/av7110}/sp8870.h                    |  0
> >  6 files changed, 22 insertions(+), 13 deletions(-)
> >  rename drivers/{media/dvb-frontends => staging/media/av7110}/sp8870.c (100%)
> >  rename drivers/{media/dvb-frontends => staging/media/av7110}/sp8870.h (100%)  
> 
> Don't you need a TODO file for these moves that says what is wrong with
> the driver and when it will be removed and to not send cleanups for it?

Yes, but it was added on the previous patch that moved the master driver
(av7110):

	https://lore.kernel.org/linux-media/4e7136434c68eabcdb66d25f44946ab794f4af0b.1622476959.git.mchehab+huawei@xxxxxxxxxx/T/#u

The TODO is just saying:

	This driver is too old and relies on a different API.
	Drop it from Kernel on a couple of versions.

(there was a typo there, I'll fix at the next version)

Thanks,
Mauro