Re: [PATCH v4 1/2] dt-bindings: gpio-mux-input: add documentation

[Linus Walleij]

On Sun, May 30, 2021 at 6:16 PM Mauri Sandberg <maukka@xxxxxxxxxxxx> wrote:

> Add documentation for a general GPIO multiplexer.
>
> Signed-off-by: Mauri Sandberg <maukka@xxxxxxxxxxxx>
> Tested-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>
> Reviewed-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>

Overall very interesting!

> +  pin-gpios:
> +    description: |
> +      The GPIO pin used as the output from the multiplexer

This is not a good name. "pin" what pin? Choose a descriptive
name, like:

parent-gpios
multiplexed-gpios
cascaded-gpios
fanout-gpios

(My order of preference.)

Otherwise these bindings look good.

Yours,
Linus Walleij