Re: linux-next: Fixes tag needs some work in the integrity tree

From: Mimi Zohar
Date: Tue Jun 01 2021 - 18:54:47 EST


On Wed, 2021-06-02 at 08:07 +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 9eea2904292c ("evm: Execute evm_inode_init_security() only when an HMAC key is loaded")
>
> Fixes tag
>
> Fixes: 26ddabfe96b ("evm: enable EVM when X509 certificate is loaded")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
>
> Probably not worth rebasing for, but can be avoided in the future by
> setting core.abbrev to 12 (or more) or (for git v2.11 or later) just
> making sure it is not set (or set to "auto").

Stephen, thank you for catching the short hash. It would be nice if
checkpatch would be updated to catch it. I recently noticed
Documentation/process/submitting-patches.rst has directions for setting
up "--pretty=fixes".

thanks,

Mimi