Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read

[Ming Lin]

On 6/1/2021 5:16 PM, Linus Torvalds wrote:
> This series passes my "looks fine, is simple and straightforward" test.
>
> One nit:
>
> On Tue, Jun 1, 2021 at 1:22 PM Ming Lin <mlin@xxxxxxxxxx> wrote:
>>
>> +               error = vm_insert_page(vma, (unsigned long)vmf->address,
>> +                                       ZERO_PAGE(0));
>
> On architectures where this matters - bad virtual caches - it would be
> better to use ZERO_PAGE(vmf->address).
>
> It doesn't make a difference on any sane architecture, but it's the
> RightThing(tm) to do.


grep -Rn ZERO_PAGE linux/arch/ | grep define

s390 and mips do use the "address" of ZERO_PAGE(address)

Fixed.