RE: [PATCH net-next 2/4] net: phy: realtek: add dt property to disable CLKOUT clock

[Joakim Zhang]

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: 2021年6月2日 6:08
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> hkallweit1@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; f.fainelli@xxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 2/4] net: phy: realtek: add dt property to disable
> CLKOUT clock
> 
> > +struct rtl821x_priv {
> > +	u32 quirks;
> 
> I'm not sure quirks is the correct word here. I would probably use features, or
> flags.

Ok, I will change to flags.

As Russell king suggests another solution, which would you prefer to?
I need a conclusion so that I can send out the V2, thanks.

Best Regards,
Joakim Zhang
> 	  Andrew