Re: [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions
From: Adrian Hunter
Date: Wed Jun 02 2021 - 07:20:52 EST
On 2/06/21 2:16 pm, Leo Yan wrote:
> Hi Adrian,
>
> On Wed, Jun 02, 2021 at 01:47:42PM +0300, Adrian Hunter wrote:
>
> [...]
>
>>> @@ -451,11 +445,7 @@ static inline u64 auxtrace_mmap__read_snapshot_head(struct auxtrace_mmap *mm)
>>> static inline u64 auxtrace_mmap__read_head(struct auxtrace_mmap *mm)
>>> {
>>> struct perf_event_mmap_page *pc = mm->userpg;
>>> -#if BITS_PER_LONG == 64 || !defined(HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT)
>>
>> The test and setup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT is not needed anymore either.
>
> Yes, I think there have two files should be cleaned:
>
> Makefile.config
> util/auxtrace.c
>
> If still miss anything, please let me know (I remembered there have a
> test case for __sync_xxx_compare_and_swap, but I cannot find it now,
> so this is why I am concern if I miss anything not).
tools/build/feature/test-sync-compare-and-swap.c