Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h
From: Manikishan Ghantasala
Date: Wed Jun 02 2021 - 11:44:18 EST
Hi Joe,
Thank you for the response, I am changing the mismatch with the real name.
Should I also prepare a new set of three patches separately as bot suggested?
Regards,
Manikishan Ghantasala
B.tech CSE
twitter | GitHub | amFOSS
On Wed, 2 Jun 2021 at 21:06, Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2021-06-02 at 17:18 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> > > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> > >
> > > "Macros with complex values should be enclosed in parantheses"
> > > by enclosing values in parantheses.
>
> parentheses
>
> > > Signed-off-by: sh4nnu <manikishanghantasala@xxxxxxxxx>
> []
> > - It looks like you did not use your "real" name for the patch on either
> > the Signed-off-by: line, or the From: line (both of which have to
> > match). Please read the kernel file, Documentation/SubmittingPatches
> > for how to do this correctly.
>
> Might be useful to have the patchbot script reduce the content of the
> message when it's identifiable.
>
> The patch itself looks OK.
>
>