Re: [PATCH] h8300: Remove unused variable

From: Mike Rapoport
Date: Wed Jun 02 2021 - 15:05:17 EST


On Thu, Jun 03, 2021 at 12:24:31AM +0530, Souptick Joarder wrote:
> Kernel test robot throws below warning ->
>
> >> arch/h8300/kernel/setup.c:72:26:
> warning: Unused variable: region [unusedVariable]
> struct memblock_region *region;
>
> Fixed it by removing unused variable.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>

I believe a Fixes: tag would be appropriate here. Otherwise

Acked-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>

> ---
> arch/h8300/kernel/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index 15280af7251c..5745a763dc78 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
>
> static void __init bootmem_init(void)
> {
> - struct memblock_region *region;
> -
> memory_end = memory_start = 0;
>
> /* Find main memory where is the kernel */
> --
> 2.25.1
>

--
Sincerely yours,
Mike.