Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
From: Rob Herring
Date: Wed Jun 02 2021 - 16:06:29 EST
On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 14577/77836 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Acked-by: Iskren Chernev <iskren.chernev@xxxxxxxxx>
>
> ---
>
> Changes since v1:
> 1. Remove the 'flags' variable.
> 2. Added ack.
> 3. Rebase - the bindings were converted to dtschema.
> ---
> .../devicetree/bindings/power/supply/maxim,max17040.yaml | 2 +-
> drivers/power/supply/max17040_battery.c | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring <robh@xxxxxxxxxx>