Re: [PATCH wq/for-next 1/2] workqueue: replace open-coded work_pending()

[Lai Jiangshan]

For both of these patches

Reviewed-by: Lai Jiangshan <jiangshanlai@xxxxxxxxx>


On Wed, Jun 2, 2021 at 7:17 PM Julian Wiedmann <jwi@xxxxxxxxxxxxx> wrote:
>
> Use the right helper to check whether a work item is currently pending.
>
> Signed-off-by: Julian Wiedmann <jwi@xxxxxxxxxxxxx>
> ---
>  kernel/workqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 50142fc08902..8a700ccfa313 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3209,7 +3209,7 @@ EXPORT_SYMBOL(flush_delayed_work);
>   */
>  bool flush_rcu_work(struct rcu_work *rwork)
>  {
> -       if (test_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(&rwork->work))) {
> +       if (work_pending(&rwork->work)) {
>                 rcu_barrier();
>                 flush_work(&rwork->work);
>                 return true;
> --
> 2.25.1
>