Re: [v5 1/5] drm/panel: add basic DP AUX backlight support

From: rajeevny
Date: Thu Jun 03 2021 - 02:26:37 EST


On 03-06-2021 05:35, Doug Anderson wrote:
Hi,

On Sun, May 30, 2021 at 8:57 AM Rajeev Nandan <rajeevny@xxxxxxxxxxxxxx> wrote:



Other than the two nits (ordering of memory allocation and word
wrapping in a comment), this looks good to me. Feel free to add my
Reviewed-by tag when you fix the nits.

NOTE: Even though I have commit access to drm-misc now, I wouldn't
feel comfortable merging this to drm-misc myself without review
feedback from someone more senior. Obviously we're still blocked on my
and Lyude's series landing first, but even assuming those just land
as-is we'll need some more adult supervision before this can land. ;-)
That being said, I personally think this looks pretty nice now.


-Doug

Thank you, Doug.

I'll address the review comments of this patch and another patch (v5 3/5)
in the next spin. I'll wait for Lyude to check this series, as she wanted
to review it in a few days.


Thanks,
Rajeev