Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap

From: Axel Lin
Date: Thu Jun 03 2021 - 06:58:34 EST


cy_huang(黃啟原) <cy_huang@xxxxxxxxxxx> 於 2021年6月3日 週四 下午6:41寫道:
>
> > cy_huang(黃啟原) <cy_huang@xxxxxxxxxxx> 於 2021年6月3日 週四 下午6:20寫道:
> > >
> > >
> > > Hi, Axel:> Use regulator_set_ramp_delay_regmap instead of open-coded.
> > > >
> > > >
> > > There's some reason.
> > > You can refer to https://lkml.org/lkml/2021/6/1/1145.
> > >
> > > It's because our ramp value order is from small to large, not large to
> > > small.
> > > It conflicts with find_closest_bigger value chosen logic.
> > I have verified the rt6160_set_ramp_delay() behavior exactly the same as
> > regulator_set_ramp_delay_regmap. (both functions get the same selector
> > for a given delay)
> >
> > Could you check if this patch works?
> Sure.

The find_closest_bigger() does not rely on ascending or descending
table entries.
Regards,
Axel