Re: [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id'

[Daniel Vetter]

On Wed, Jun 02, 2021 at 07:20:35PM +0300, Laurent Pinchart wrote:
> Hi Lee,
> 
> Thank you for the patch.
> 
> On Wed, Jun 02, 2021 at 03:32:51PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead
> > 
> > Cc: Hyun Kwon <hyun.kwon@xxxxxxxxxx>
> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

I'm assuming you'll merge these two for xlnx somehow?
-Daniel

> 
> > ---
> >  drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 109d627968ac0..ca1161ec9e16f 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -91,7 +91,7 @@ struct zynqmp_disp_format {
> >  };
> >  
> >  /**
> > - * enum zynqmp_disp_id - Layer identifier
> > + * enum zynqmp_disp_layer_id - Layer identifier
> >   * @ZYNQMP_DISP_LAYER_VID: Video layer
> >   * @ZYNQMP_DISP_LAYER_GFX: Graphics layer
> >   */
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch