Re: [patch 8/8] x86/fpu: Deduplicate copy_xxx_to_xstate()

From: Andy Lutomirski
Date: Thu Jun 03 2021 - 12:56:10 EST


On 6/2/21 2:55 AM, Thomas Gleixner wrote:
> copy_user_to_xstate() and copy_kernel_to_xstate() are almost identical
> except for the copy function.
>
> Unify them.

I keep looking at call sites of these functions and being vaguely
confused. Maybe copy_to_userabi_xstate() would make the purpose of
these functions clearer?

Otherwise, and even if you don't like my suggestion:

Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>