Re: [PATCH] power: supply: surface-charger: Fix type of integer variable

[Maximilian Luz]

On 5/11/21 11:24 AM, Maximilian Luz wrote:
> The ac->state field is __le32, not u32. So change the variable we're
> temporarily storing it in to __le32 as well.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>

Friendly ping :)

> ---
>   drivers/power/supply/surface_charger.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index 81a5b79822c9..a060c36c7766 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -66,7 +66,7 @@ struct spwr_ac_device {
>   
>   static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
>   {
> -	u32 old = ac->state;
> +	__le32 old = ac->state;
>   	int status;
>   
>   	lockdep_assert_held(&ac->lock);