Re: [PATCH Part1 RFC v3 03/22] x86/sev: Save the negotiated GHCB version

[Borislav Petkov]

On Wed, Jun 02, 2021 at 09:03:57AM -0500, Brijesh Singh wrote:
> +/*
> + * Since feature negotiation related variables are set early in the boot
> + * process they must reside in the .data section so as not to be zeroed
> + * out when the .bss section is later cleared.
> + */

>From previous review:

 ...

   *
   * GHCB protocol version negotiated with the hypervisor.
   */

You need to document what this variable is used for so add a comment
over it please.

> +static u16 ghcb_version __section(".data");
> +

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette