Re: [PATCH V3 4/9] tracing/hwlat: Implement the per-cpu mode

[Steven Rostedt]

On Fri, 14 May 2021 22:51:13 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:

>  void trace_hwlat_callback(bool enter)
>  {
> -	if (smp_processor_id() != nmi_cpu)
> +	struct hwlat_kthread_data *kdata = get_cpu_data();
> +
> +	if (kdata->kthread)

Shouldn't that be:

	if (!kdata->kthread)

?

-- Steve

>  		return;
>  
>  	/*
> @@ -158,13 +173,13 @@ void trace_hwlat_callback(bool enter)
>  	 */
>  	if (!IS_ENABLED(CONFIG_GENERIC_SCHED_CLOCK)) {
>  		if (enter)
> -			nmi_ts_start = time_get();
> +			kdata->nmi_ts_start = time_get();
>  		else
> -			nmi_total_ts += time_get() - nmi_ts_start;
> +			kdata->nmi_total_ts += time_get() - kdata->nmi_ts_start;
>  	}
>  
>  	if (enter)
> -		nmi_count++;
> +		kdata->nmi_count++;
>  }
>