Re: [PATCH net-next] xfrm: Return the correct errno code

[Herbert Xu]

On Fri, Jun 04, 2021 at 09:46:52AM +0800, Zheng Yongjun wrote:
> When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
> ---
>  net/xfrm/xfrm_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
> index f0aecee4d539..4f9c86807bc4 100644
> --- a/net/xfrm/xfrm_user.c
> +++ b/net/xfrm/xfrm_user.c
> @@ -3159,7 +3159,7 @@ static struct xfrm_policy *xfrm_compile_policy(struct sock *sk, int opt,
>  
>  	xp = xfrm_policy_alloc(net, GFP_ATOMIC);
>  	if (xp == NULL) {
> -		*dir = -ENOBUFS;
> +		*dir = -ENOMEM;

Nack.  ENOBUFS has a specific meaning in the network stack.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt