Re: [PATCH v4 0/3] extcon: sm5502: Add support for SM5504

[Chanwoo Choi]

On 6/3/21 5:52 PM, Stephan Gerhold wrote:
> This patch series adds support for SM5504 to the existing extcon-sm5502
> driver. SM5502 and SM5504 are fairly similar so support for SM5504 can
> be added with a few simple changes to the code.
> 
> I tested this patch series on both SM5502 (Samsung Galaxy A5 2015)
> and SM5504 (Samsung Galaxy S4 Mini Value Edition) and it seems to work
> just fine for both.
> 
> ---
> Changes in v4:
>   - Add NULL check for .parse_irq (suggested by Chanwoo Choi)
>   - Add Rob's Acked-by: on the dt-bindings patch
> Changes in v3:
>   - Drop patch 1-4 (already applied)
>   - Avoid if (type == TYPE_SM5504) everywhere in the code, instead
>     introduce a struct sm5502_type that encodes chip-specific information.
> Changes in v2: Fix compile warning in last patch
> 
> v3: https://lore.kernel.org/lkml/20210601200007.218802-1-stephan@xxxxxxxxxxx/
> v2: https://lore.kernel.org/lkml/20210531133438.3511-1-stephan@xxxxxxxxxxx/
> v1: https://lore.kernel.org/lkml/20210520112334.129556-1-stephan@xxxxxxxxxxx/
> 
> Stephan Gerhold (3):
>   dt-bindings: extcon: sm5502: Document siliconmitus,sm5504-muic
>   extcon: sm5502: Refactor driver to use chip-specific struct
>   extcon: sm5502: Add support for SM5504
> 
>  .../extcon/siliconmitus,sm5502-muic.yaml      |   6 +-
>  drivers/extcon/Kconfig                        |   2 +-
>  drivers/extcon/extcon-sm5502.c                | 200 +++++++++++++++---
>  drivers/extcon/extcon-sm5502.h                |  82 ++++++-
>  4 files changed, 252 insertions(+), 38 deletions(-)
> 

Applied them. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics