Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

[hongbo li]

Thank you for your review, I will resend this patch.
Regards,
Hongbo

Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> 于2021年6月3日周四 下午8:34写道：
>
> On Tue, Jun 01, 2021 at 09:05:52PM +0800, Hongbo Li wrote:
> > From: Hongbo Li <herberthbli@xxxxxxxxxxx>
> >
> > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> > test_akcipher_one(), it will set public key for every test vector,
> > and don't free ec->Q. This will cause a memory leak.
> >
> > This patch alloc ec->Q in sm2_ec_ctx_init().
> >
> > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> > Signed-off-by: Hongbo Li <herberthbli@xxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # v5.10+
> > Reviewed-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
> > ---
> >  crypto/sm2.c | 24 ++++++++++--------------
> >  1 file changed, 10 insertions(+), 14 deletions(-)
>
> Your patch has been discarded by patchwork because you didn't
> update the Subject.  The usual method is to use a version prefix
> such as v2, v3, etc. so that the Subject remains distinct.
>
> Please resubmit with a new Subject.
>
> Oh and don't cc stable@xxxxxxxxxxxxxxx.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt