Re: [PATCH 1/3] perf stat: Check return value of asprintf() properly

[Ian Rogers]

On Wed, Jun 2, 2021 at 2:22 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> It returns -1 on error, so checking with 0 would not work.
>
> Fixes: 12279429d862 ("perf stat: Uniquify hybrid event name")
> Cc: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/util/stat-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index b759dfd633b4..04afd41b6067 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -564,7 +564,7 @@ static void uniquify_event_name(struct evsel *counter)
>                                        counter->name, counter->pmu_name);
>                 }
>
> -               if (ret) {
> +               if (ret > 0) {
>                         free(counter->name);
>                         counter->name = new_name;
>                 }
> --
> 2.32.0.rc0.204.g9fa02ecfa5-goog
>