Re: [RFC PATCH 0/1] Initialize debugfs/ksysfs earlier?

From: Greg Kroah-Hartman
Date: Fri Jun 04 2021 - 08:57:11 EST


On Thu, Jun 03, 2021 at 11:00:00PM +0300, Adrian Ratiu wrote:
> Hi and thank you for the quick response!
>
> On Thu, 03 Jun 2021, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Jun 03, 2021 at 03:55:33PM +0300, Adrian Ratiu wrote:
> > > Hi Greg & all, I would like to add a new debugfs file like in the
> > > next patch but I'm having a problem with commit 56348560d495
> > > ("debugfs: do not attempt to create a new file before the filesystem
> > > is initalized").
> >
> > You should have had a problem before that commit happened as well,
> > right?
> >
>
> Actually no, it works without problems before commit 56348560d495 and also
> works if I revert that commit or move the debugfs_init() and its dependency
> ksysfs_init() before the driver core init.

And the file shows up properly? How can that be? Is it ok to create a
file before the superblock is created in the system? For some reason I
thought these were just silently failing and no one noticed. Maybe we
should revisit that commit...

thanks,

greg k-h