Re: [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc

[Arnd Bergmann]

On Fri, Jun 4, 2021 at 2:06 PM Alexandre Ghiti <alex@xxxxxxxx> wrote:
>
> Fix BUILTIN_DTB config which resulted in a dtb that was actually not built
> into the Linux image: in the same manner as Canaan soc does, create an object
> file from the dtb file that will get linked into the Linux image.
>
> Signed-off-by: Alexandre Ghiti <alex@xxxxxxxx>

Along the same lines as the comment that Jisheng Zhang made on the fixed
address, building a dtb into the kernel itself fundamentally breaks generic
kernel images.

I can understand using it on K210, which is extremely limited and wouldn't
run a generic kernel anyway, but for normal platforms like microchip and
sifive, it would be better to disallow CONFIG_BUILTIN_DTB in Kconfig
and require a non-broken boot loader.

      Arnd