Re: [PATCH v1 1/1] device property: Unify access to of_node
From: kernel test robot
Date: Fri Jun 04 2021 - 12:17:06 EST
Hi Andy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210604]
[cannot apply to driver-core/driver-core-testing linux/master linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2 v5.13-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/device-property-Unify-access-to-of_node/20210604-211443
base: ccc252d2e818f6a479441119ad453c3ce7c7c461
config: sparc64-randconfig-s032-20210604 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/dfc2a97acf9b5c5ba11d180bf411721f723a9042
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andy-Shevchenko/device-property-Unify-access-to-of_node/20210604-211443
git checkout dfc2a97acf9b5c5ba11d180bf411721f723a9042
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
sparse warnings: (new ones prefixed by >>)
>> drivers/base/property.c:875:55: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct fwnode_handle *fwnode @@ got struct fwnode_handle const *fwnode @@
drivers/base/property.c:875:55: sparse: expected struct fwnode_handle *fwnode
drivers/base/property.c:875:55: sparse: got struct fwnode_handle const *fwnode
drivers/base/property.c:890:62: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct fwnode_handle *fwnode @@ got struct fwnode_handle const *fwnode @@
drivers/base/property.c:890:62: sparse: expected struct fwnode_handle *fwnode
drivers/base/property.c:890:62: sparse: got struct fwnode_handle const *fwnode
vim +875 drivers/base/property.c
863
864 bool device_dma_supported(struct device *dev)
865 {
866 const struct fwnode_handle *fwnode = dev_fwnode(dev);
867
868 /* For DT, this is always supported.
869 * For ACPI, this depends on CCA, which
870 * is determined by the acpi_dma_supported().
871 */
872 if (is_of_node(fwnode))
873 return true;
874
> 875 return acpi_dma_supported(to_acpi_device_node(fwnode));
876 }
877 EXPORT_SYMBOL_GPL(device_dma_supported);
878
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip