Re: [PATCH v5 4/6] gpiolib: acpi: Add acpi_gpio_get_io_resource()

From: Daniel Scally
Date: Fri Jun 04 2021 - 12:54:58 EST



On 04/06/2021 15:33, Andy Shevchenko wrote:
> On Fri, Jun 04, 2021 at 03:09:43PM +0100, Daniel Scally wrote:
>> On 04/06/2021 14:01, Andy Shevchenko wrote:
>>> On Thu, Jun 03, 2021 at 11:40:05PM +0100, Daniel Scally wrote:
>>>> Add a function to verify that a given acpi_resource represents an IO
>>>> type GPIO resource, and return it if so.
>>> I would rephrase this to something like:
>>>
>>> "Add a function to verify that a given ACPI resource represents a GpioIo() type
>>> of resource, and return it if so."
>>>
>>> I can amend when applying to my branch.
>>>
>> That wording is perfectly fine by me
> These two patches (with mentioned amendments) pushed to my review and testing
> queue, thanks!
>
> I'll send PR next week to all stakeholders.
>
Great - thanks very much!