Re: [PATCH 5/7] mm/thp: fix page_vma_mapped_walk() if huge page mapped by ptes

From: Matthew Wilcox
Date: Fri Jun 04 2021 - 13:43:25 EST


On Fri, Jun 04, 2021 at 07:24:02PM +0300, Kirill A. Shutemov wrote:
> > /* when pud is not present, pte will be NULL */
> > - pvmw->pte = huge_pte_offset(mm, pvmw->address, page_size(page));
> > + pvmw->pte = huge_pte_offset(mm, pvmw->address,
> > + page_size(pvmw->page));
>
> AFAICS, it exactly fits into 80-column.

.. not after putting the 'pvmw->' before 'page'.

> > if (!pvmw->pte)
> > return false;
> >
> > - pvmw->ptl = huge_pte_lockptr(page_hstate(page), mm, pvmw->pte);
> > + pvmw->ptl = huge_pte_lockptr(page_hstate(pvmw->page),
> > + mm, pvmw->pte);
>
> And this one end on 79.

likewise. I mean, the 'mm' could go on the previous line, but that's
beyond my level of code format caring.