Re: [PATCH][next] scsi: mpi3mr: Fix fall-through warning for Clang

From: Kees Cook
Date: Fri Jun 04 2021 - 14:22:20 EST


On Thu, Jun 03, 2021 at 09:35:30PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fall-through warning by explicitly adding a break statement instead
> of just letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Looks right.

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook