Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages()

[Alex Deucher]

On Fri, Jun 4, 2021 at 7:11 AM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
>
> Am 03.06.21 um 18:09 schrieb Liam Howlett:
> > Use vma_lookup() to find the VMA at a specific address.  As vma_lookup()
> > will return NULL if the address is not within any VMA, the start address
> > no longer needs to be validated.
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
>
> Reviewed-by: Christian König <christian.koenig@xxxxxxx>
>

I'm fine to have this go through whatever tree makes sense.

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > index 7cb7ffdd1900..dfb5ca3f8da8 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > @@ -680,9 +680,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages)
> >               return -ESRCH;
> >
> >       mmap_read_lock(mm);
> > -     vma = find_vma(mm, start);
> > +     vma = vma_lookup(mm, start);
> >       mmap_read_unlock(mm);
> > -     if (unlikely(!vma || start < vma->vm_start)) {
> > +     if (unlikely(!vma)) {
> >               r = -EFAULT;
> >               goto out_putmm;
> >       }
>