Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Fri Jun 04 2021 - 18:35:38 EST


Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:19, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> ---
>> net/rxrpc/af_rxrpc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
>> index 41671af6b33f..2b5f89713e36 100644
>> --- a/net/rxrpc/af_rxrpc.c
>> +++ b/net/rxrpc/af_rxrpc.c
>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>> switch (rx->sk.sk_state) {
>> case RXRPC_UNBOUND:
>> rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
>> + break;
>> case RXRPC_CLIENT_UNBOUND:
>> case RXRPC_CLIENT_BOUND:
>> break;
>>