Re: [PATCH 1/6] arm64: dts: meson: vim3: add serial aliases

[Martin Blumenstingl]

On Sat, Jun 5, 2021 at 8:23 AM <xieqinick@xxxxxxxxx> wrote:
>
> From: Nick Xie <nick@xxxxxxxxxx>
>
> Add serial aliases for Khadas VIM3/3L.
>
> Signed-off-by: Nick Xie <nick@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 66d67524b031..4686ea7abe0b 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -13,6 +13,10 @@
>  / {
>         aliases {
>                 serial0 = &uart_AO;
> +               serial1 = &uart_A;
uart_A is used for the Bluetooth module so with mainline Linux it will
not get a /dev/ttyAMLx character device
For that reason we are not adding an alias for uart_A when a new
board.dts is added

I suggest that you also drop this alias here because it is not visible
to the user ever
Same applies to VIM1 and VIM2 as well


Best regards,
Martin