Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci_drv()

From: Wei Liu
Date: Sat Jun 05 2021 - 06:40:26 EST


On Fri, Jun 04, 2021 at 04:26:22PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 02, 2021 at 10:32:06AM +0000, Wei Liu wrote:
> > On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
> > > Add check for hv_is_hyperv_initialized() at the top of init_hv_pci_drv(),
> > > so if the pci-hyperv driver is force-loaded on non Hyper-V platforms, the
> > > init_hv_pci_drv() will exit immediately, without any side effects, like
> > > assignments to hvpci_block_ops, etc.
> > >
> > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > > Reported-and-tested-by: Mohammad Alqayeem <mohammad.alqyeem@xxxxxxxxxxx>
> >
> > Hello PCI subsystem maintainers, are you going to take this patch or
> > shall I?
>
> This was mistakenly assigned to me, so I reassigned it back to
> Lorenzo.
>
> If you *do* take this, please at least update it to follow the PCI
> commit log conventions, e.g.,
>
> PCI: hv: Add check ...
>
> and wrap the text so it fits in 75 columns.

Lorenzo already picked up two Hyper-V PCI patches from Long Li. I think
leaving this to him is better.

Wei.