Re: [PATCHv2 2/2] kvm: x86: implement KVM PM-notifier

[Marc Zyngier]

On 2021-06-05 11:48, Sergey Senozhatsky wrote:
> On (21/06/05 10:00), Marc Zyngier wrote:
> > > +static int kvm_arch_suspend_notifier(struct kvm *kvm)
> > > +{
> > > +	struct kvm_vcpu *vcpu;
> > > +	int i, ret;
> > > +
> > > +	mutex_lock(&kvm->lock);
> > > +	kvm_for_each_vcpu(i, vcpu, kvm) {
> > > +		ret = kvm_set_guest_paused(vcpu);
> > > +		if (ret) {
> > > +			pr_err("Failed to pause guest VCPU%d: %d\n",
> > > +			       vcpu->vcpu_id, ret);
> >
> > how useful the pr_err() is, given that it contains no information
> > that would help identifying which guest failed to pause.
>
> Do other printk-s contain such info? All I can see so far is
> `#define pr_fmt(fmt) "kvm-guest: " fmt` which doesn't point
> at any particular VM.

Look for kvm_{err,info,debug...} and vcpu_{err,debug...}, all of
which will at least give you a PID. Even x86 uses it.

        M.
--
Jazz is not dead. It just smells funny...