Re: [RESEND net-next 1/2] net: hns3: add support for PTP

From: Richard Cochran
Date: Sat Jun 05 2021 - 11:41:01 EST


On Sat, Jun 05, 2021 at 06:37:19PM +0800, huangguangbin (A) wrote:
> > Need mutex or spinlock to protest against concurrent access.
> >
> Ok, thank you. Is it better to add mutex or spinlock in the public place, like ptp_clock_adjtime()?
> Then there's no need to add mutex or spinlock in all the drives.

No, that is a terrible idea. The class layer has no idea about the
hardware implementation. Only the driver knows that.

Thanks,
Richard