Re: [PATCH] riscv: sifive: fix Kconfig errata warning

[Randy Dunlap]

ping. anyone?
thanks.

On 5/22/21 2:20 PM, Randy Dunlap wrote:
> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
> not set, so SOC_SIFIVE should either depend on or select
> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
> warning.
> 
> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
>   Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
>   Selected by [y]:
>   - SOC_SIFIVE [=y]
> 
> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Cc: Vincent Chen <vincent.chen@xxxxxxxxxx>
> ---
>  arch/riscv/Kconfig.socs |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
> +++ linux-next-20210521/arch/riscv/Kconfig.socs
> @@ -14,6 +14,7 @@ config SOC_SIFIVE
>  	select CLK_SIFIVE
>  	select CLK_SIFIVE_PRCI
>  	select SIFIVE_PLIC
> +	select RISCV_ERRATA_ALTERNATIVE
>  	select ERRATA_SIFIVE
>  	help
>  	  This enables support for SiFive SoC platform hardware.
> 


-- 
~Randy