Re: [PATCH net-next v2] net: gemini: Use devm_platform_get_and_ioremap_resource()

[Yang Yingliang]

Hi,

On 2021/6/5 23:17, Linus Walleij wrote:
> On Sat, Jun 5, 2021 at 2:32 PM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
>
> > Use devm_platform_get_and_ioremap_resource() to simplify
> > code.
> >
> > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> (...)
> > -       dmares = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -       gmacres = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> Should you not also delete the local variables
> dmares and gmacres? I doubt they are used
> after this.
They are used to print message before returning gemini_ethernet_port_probe()
static int gemini_ethernet_port_probe(struct platform_device *pdev)
{
[...]
        netdev_info(netdev,
                    "irq %d, DMA @ 0x%pap, GMAC @ 0x%pap\n",
                    port->irq, &dmares->start,
                    &gmacres->start);
        return 0;

unprepare:
        clk_disable_unprepare(port->pclk);
        return ret;
}

Thanks,
Yang
> Yours,
> Linus Walleij
> .