RE: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG

[Ricky WU]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, June 4, 2021 10:48 PM
> To: Ricky WU
> Cc: arnd@xxxxxxxx; bhelgaas@xxxxxxxxxx; rui_feng@xxxxxxxxxxxxxx;
> ulf.hansson@xxxxxxxxxx; vaibhavgupta40@xxxxxxxxx;
> yang.lee@xxxxxxxxxxxxxxxxx; keitasuzuki.park@xxxxxxxxxxxxxxxxxxxx;
> chris.chiu@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and
> MODE_CFG
> 
> On Fri, Jun 04, 2021 at 10:42:11PM +0800, ricky_wu@xxxxxxxxxxx wrote:
> > From: Ricky Wu <ricky_wu@xxxxxxxxxxx>
> >
> > Divide Realtek Card Reader Group into two different modes
> > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250 Change back to use
> > original way to control aspm
> 
> What is "aspm"?
> 
Active State Power Management (ASPM)
rtsx_comm_set_aspm: ASPM control function for our driver
to make sure not enter power saving in process of init and card_detcct 

> > +#define ASPM_MODE_CFG		0x01
> > +#define ASPM_MODE_REG		0x02
> > +	u8				aspm_mode;
> 
> Why not use an enum?
> 

It is ok, we can have a V2 to use enum

> thanks,
> 
> greg k-h
> ------Please consider the environment before printing this e-mail.