Re: [PATCH RFC] x86: remove toolchain check for X32 ABI capability

From: Masahiro Yamada
Date: Mon Jun 07 2021 - 03:40:47 EST


On Sun, Feb 28, 2021 at 3:49 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> On Sun, Feb 28, 2021 at 12:15:16PM +0900, Masahiro Yamada wrote:
> > On Sun, Feb 28, 2021 at 3:41 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > This commit reverts 0bf6276392e9 ("x32: Warn and disable rather than
> > > error if binutils too old").
> > >
> > > The help text in arch/x86/Kconfig says enabling the X32 ABI support
> > > needs binutils 2.22 or later. This is met because the minimal binutils
> > > version is 2.23 according to Documentation/process/changes.rst.
> > >
> > > I would not say I am not familiar with toolchain configuration, but
> >
> > I mean:
> > I would not say I am familiar ...
> > That is why I added RFC.
> >
> > I appreciate comments from people who are familiar
> > with toolchains (binutils, llvm).
> >
> > If this change is not safe,
> > we can move this check to Kconfig at least.
>
> Hi Masahiro,
>
> As Fangrui pointed out, there are two outstanding issues with x32 with
> LLVM=1, both seemingly related to LLVM=1.

Is this still a problem for Clang built Linux?



> https://github.com/ClangBuiltLinux/linux/issues/514

I am not tracking the status.
What was the conclusion?

> https://github.com/ClangBuiltLinux/linux/issues/1141


This got marked "unreproducible"

>
> Additionally, there appears to be one from Arnd as well but that one has
> received no triage yet.
>
> https://github.com/ClangBuiltLinux/linux/issues/1205

Same as well.


>
> I intend to test this patch as well as a few others at some point in the
> coming week although I am having to play sysadmin due to moving servers
> so I might not be able to get to it until later in the week.
>
> Cheers,
> Nathan
>


--
Best Regards
Masahiro Yamada