Re: [PATCH] arm64: dts: rockchip: add EEPROM node for NanoPi R4S

[Chen-Yu Tsai]

Hi,

On Mon, Jun 7, 2021 at 4:19 PM Tianling Shen <cnsztl@xxxxxxxxx> wrote:
>
> NanoPi R4S has a EEPROM attached to the 2nd I2C bus (U92), which
> stores the MAC address.
>
> Signed-off-by: Tianling Shen <cnsztl@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
> index cef4d18b599d..4a82f50a07c5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
> @@ -68,6 +68,15 @@
>         status = "disabled";
>  };
>
> +&i2c2 {
> +       eeprom@51 {
> +               compatible = "microchip,24c02", "atmel,24c02";

The actual part number is Microchip 24AA025E48, but I don't think
the way this device splits its storage area is easy to support
without additional modifications to the driver.

> +               reg = <0x51>;
> +               pagesize = <16>;
> +               read-only; /* This holds our MAC */

Please also add the size, as well as a cell defining the offset
and length to the MAC address. The gmac node can then reference
this with:

    nvmem-cells = <&mac_address>;
    nvmem-cells-names = "mac-address";

which will actually pick up the MAC address.


Regards
ChenYu

> +       };
> +};
> +
>  &i2c4 {
>         status = "disabled";
>  };
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel