Re: [PATCH] reset: berlin: support module build

[Jisheng Zhang]

On Mon, 07 Jun 2021 11:49:45 +0200
Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:


> 
> 
> On Mon, 2021-06-07 at 17:44 +0800, Jisheng Zhang wrote:
> > On Mon, 07 Jun 2021 11:23:57 +0200
> > Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> >
> >  
> > >
> > > On Thu, 2021-05-20 at 17:13 +0800, Jisheng Zhang wrote:  
> > > > Make reset-berlin driver to be tristate module, support to build as
> > > > a module, this is useful for GKI.
> > > >
> > > > Partially revert commit ed4dba99cae8 ("reset: berlin: make it
> > > > explicitly non-modular")
> > > >
> > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx>
> > > > ---
> > > >  drivers/reset/Kconfig        |  4 ++--
> > > >  drivers/reset/reset-berlin.c | 10 ++++++++--
> > > >  2 files changed, 10 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > > > index 3e7f55e44d84..1e7443a4dae1 100644
> > > > --- a/drivers/reset/Kconfig
> > > > +++ b/drivers/reset/Kconfig
> > > > @@ -43,8 +43,8 @@ config RESET_BCM6345
> > > >         This enables the reset controller driver for BCM6345 SoCs.
> > > >
> > > >  config RESET_BERLIN
> > > > -     bool "Berlin Reset Driver" if COMPILE_TEST
> > > > -     default ARCH_BERLIN
> > > > +     tristate "Berlin Reset Driver"
> > > > +     depends on ARCH_BERLIN || COMPILE_TEST  
> > >
> > > Is there a reason not to keep "default ARCH_BERLIN"?
> > >  
> >
> > Hi,
> >
> > After this patch, the reset driver will be built as module in most cases
> > so I removed default ARCH_BERLIN  
> 
> I see, how about "default m if ARCH_BERLIN" then?

Good idea. I think "default m" is enough, because we have a "depends on
ARCH_BERLIN || COMPILE_TEST" above

Will send out v2 soon

Thanks

> 
> I'd just like to avoid anybody getting surprised by a suddenly
> deactivated reset controller driver.
> 
> regards
> Philipp